-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New]forbid-component-props
: add propNamePattern
option
#3774
Conversation
…llow prop name patterns
380e32c
to
51d342b
Compare
Can we rerun test for failing checks? Not sure of cause of failure |
it's a real failure; i think it's that destructuring syntax doesn't work in function signatures in node 4. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3774 +/- ##
==========================================
+ Coverage 97.62% 97.80% +0.17%
==========================================
Files 134 134
Lines 9617 9640 +23
Branches 3488 3496 +8
==========================================
+ Hits 9389 9428 +39
+ Misses 228 212 -16 ☔ View full report in Codecov by Sentry. |
Additionally, eslint configs shouldn't have regexes in them; this needs to be a glob not a regex (name it |
forbid-component-props
: add propNameRegex
optionforbid-component-props
: add propNamePattern
option
Updated to use glob pattern instead of regex |
Add
propNamePattern
option to allow / disallow prop name patternsCloses #3681. Closes #3686.