Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New]forbid-component-props: add propNamePattern option #3774

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jun 27, 2024

Add propNamePattern option to allow / disallow prop name patterns

Closes #3681. Closes #3686.

@ljharb ljharb force-pushed the master branch 2 times, most recently from 380e32c to 51d342b Compare July 4, 2024 15:25
@akulsr0
Copy link
Contributor Author

akulsr0 commented Jul 11, 2024

Can we rerun test for failing checks? Not sure of cause of failure

@ljharb
Copy link
Member

ljharb commented Jul 11, 2024

it's a real failure; i think it's that destructuring syntax doesn't work in function signatures in node 4.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (cef8123) to head (b8514e1).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3774      +/-   ##
==========================================
+ Coverage   97.62%   97.80%   +0.17%     
==========================================
  Files         134      134              
  Lines        9617     9640      +23     
  Branches     3488     3496       +8     
==========================================
+ Hits         9389     9428      +39     
+ Misses        228      212      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Jul 11, 2024

Additionally, eslint configs shouldn't have regexes in them; this needs to be a glob not a regex (name it propNamePattern, maybe?)

@akulsr0 akulsr0 changed the title [New]forbid-component-props: add propNameRegex option [New]forbid-component-props: add propNamePattern option Jul 12, 2024
@akulsr0
Copy link
Contributor Author

akulsr0 commented Jul 12, 2024

Updated to use glob pattern instead of regex

@ljharb ljharb merged commit 6ce58e5 into jsx-eslint:master Jul 15, 2024
343 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants