[readme] Fix shared settings link #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Sep 30, 2024
ljharb
force-pushed
the
mgenglder/fix-shared-settings-link
branch
from
a4d4c25
to
1f95a24
Compare
ljharb
changed the title
README.md example
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 1, 2024
##### [`v7.37.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7371---20241001) ##### Fixed - \[meta] do not npmignore `d.ts` files ([#3836][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[readme] Fix shared settings link ([#3834][] [@MgenGlder](https://github.com/MgenGlder)) [#3836]: jsx-eslint/eslint-plugin-react#3836 [#3834]: jsx-eslint/eslint-plugin-react#3834
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Oct 1, 2024
##### [v7.37.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7371---20241001) ##### Fixed - \[meta] do not npmignore `d.ts` files ([#3836][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[readme] Fix shared settings link ([#3834][] [@MgenGlder](https://github.com/MgenGlder)) [#3836]: jsx-eslint/eslint-plugin-react#3836 [#3834]: jsx-eslint/eslint-plugin-react#3834
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 1, 2024
##### [`v7.37.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7371---20241001) ##### Fixed - \[meta] do not npmignore `d.ts` files ([#3836][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[readme] Fix shared settings link ([#3834][] [@MgenGlder](https://github.com/MgenGlder)) [#3836]: jsx-eslint/eslint-plugin-react#3836 [#3834]: jsx-eslint/eslint-plugin-react#3834
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 1, 2024
##### [`v7.37.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7371---20241001) ##### Fixed - \[meta] do not npmignore `d.ts` files ([#3836][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[readme] Fix shared settings link ([#3834][] [@MgenGlder](https://github.com/MgenGlder)) [#3836]: jsx-eslint/eslint-plugin-react#3836 [#3834]: jsx-eslint/eslint-plugin-react#3834
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 1, 2024
##### [`v7.37.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7371---20241001) ##### Fixed - \[meta] do not npmignore `d.ts` files ([#3836][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[readme] Fix shared settings link ([#3834][] [@MgenGlder](https://github.com/MgenGlder)) [#3836]: jsx-eslint/eslint-plugin-react#3836 [#3834]: jsx-eslint/eslint-plugin-react#3834
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Oct 1, 2024
##### [v7.37.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7371---20241001) ##### Fixed - \[meta] do not npmignore `d.ts` files ([#3836][] [@ljharb](https://github.com/ljharb)) ##### Changed - \[readme] Fix shared settings link ([#3834][] [@MgenGlder](https://github.com/MgenGlder)) [#3836]: jsx-eslint/eslint-plugin-react#3836 [#3834]: jsx-eslint/eslint-plugin-react#3834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
README.mdfile.As I was upgrading my eslint configuration for a personal project, I found that I needed to use the shared settings feature to configure my React version. The link in the docs section navigates to the main page but doesn't anchor you to the section that discusses the shared settings. I think the original link broke at some point. This PR fixes it.