To support annotation in plot.ly javascript. #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a couple examples (in the test folder tech.tablesaw.examples) that show this working with other plots? |
Hi @xcjusuih, Do you think you might be able to provide some examples in the near future or should we do a release without these changes? |
|
I think perhaps in next week as I am busy with final exam. |
|
that's fine. Good luck with your exams.
…On Mon, May 31, 2021 at 9:51 AM xcjusuih ***@***.***> wrote:
I think perhaps in next week as I am busy with final exam.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#944 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2FPAWKLPUK4BVEIXGO6VLTQOH7FANCNFSM45KRQ5BQ>
.
|
|
i guess we can go without the example code as there are tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
I add basic support for annotation in plot.ly as issue #615 want. It can support most of apis in annotation.
Testing
Did you add a unit test?
I write 2 tests for 2 conditions in guideline of annotation and both of them have past.