make module factory return a module name instead a module instance as…

[drpicox]

… angular libraries does

See: https://github.com/angular/bower-angular-animate/blob/fc8c108cbb1d8486f725386b943d35730caf3358/index.js as example:

    require('./angular-animate');
    module.exports = 'ngAnimate';

So you can do:

    module.exports = angular.module('yourModule', [
        require('./yourStuff'),
        require('./moreOfYourStuff'),
        require('angular-animate'),
        require('angular-route'),
        require('angular-chart'),
    ]).name;

[jtblin]

Didn't know about that. Is that backward compatible?

[drpicox]

Nope, it is not backward compatible, at least in theory.

Why it is not backward compatible?

It is because users are doing:

module.exports = angular.module('yourModule', [
    require('./yourStuff'),
    require('./moreOfYourStuff'),
    require('angular-animate'),
    require('angular-route'),
    require('angular-chart').name,
]).name;

or

require('angular-chart');

module.exports = angular.module('yourModule', [
    require('./yourStuff'),
    require('./moreOfYourStuff'),
    require('angular-animate'),
    require('angular-route'),
    "chart.js",
]).name;

With the proposed change people can do:

module.exports = angular.module('yourModule', [
    require('./yourStuff'),
    require('./moreOfYourStuff'),
    require('angular-animate'),
    require('angular-route'),
    require('angular-chart'),
]).name;

or, not recommended - still the same -,

require('angular-chart');

module.exports = angular.module('yourModule', [
    require('./yourStuff'),
    require('./moreOfYourStuff'),
    require('angular-animate'),
    require('angular-route'),
    "chart.js",
]).name;

So, in the worst case, user must remove 5 characters.

[jtblin]

Ok, thanks. I am not going to introduce a breaking change right now. I'm waiting on chart.js 2.0 final release at which point there will be breaking changes so I'll publish a 1.0 for this library and can review this then.

[jtblin]

Thanks for the idea, this is now done on chartjs-2.0 branch and will be published soon.

[drpicox]

Nice!