Swap merge args, rename config.entries --> config.include #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make transforms relative or use require
|
I discussed this with dcode and he said we should use entries, and not include, even though include matches typescript ergonomics. Feel free to talk this over with dcode and maxgraey, and I won't close this pr. |
|
I only change that because you used includes in your examples. I'm fine changing to entries. Also I want to add a |
|
Also I tested this with NEAR projects and it works like a charm! Which means I don't have to support a separate compile tool. |
Also fixed missing ;'s
|
Yeah this looks great! I forgot about transform paths :). |
jtenner
reviewed
Jul 9, 2020
| @@ -283,10 +283,19 @@ exports.main = function main(argv, options, callback) { | |||
| while (asconfig) { | |||
| // merge target first, then merge options, then merge extended asconfigs | |||
| if (asconfig.targets && asconfig.targets[target]) { | |||
| args = optionsUtil.merge(exports.options, args, asconfig.targets[target]); | |||
| args = optionsUtil.merge(exports.options, asconfig.targets[target], args); | |||
There was a problem hiding this comment.
I switched it back, because targets should be respected over default "options".
added 3 commits
July 10, 2020 14:17
Also exported args and argv from asc And swapped back order of args to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make transforms relative or use require