Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Windows tests working & passing. #560

Merged
merged 27 commits into from
Apr 10, 2022
Merged

Get Windows tests working & passing. #560

merged 27 commits into from
Apr 10, 2022

Conversation

jtv
Copy link
Owner

@jtv jtv commented Apr 9, 2022

I added an appveyor.yml. This should mean I no longer have to configure appveyor in the web UI. And more of the test is set up automatically, without awkward scripting in various convoluted languages.

But it also gave me the opportunity to get the tests running on Windows. And guess what? They didn't all pass! The test for asynchronous connection (using pqxx::connecting) would hang. Turns out it was completely unnecessary for libpqxx to manage blocking/nonblocking mode on the socket. So that's fixed now.

jtv added 27 commits April 9, 2022 20:34
This should mean I no longer have to configure appveyor in the web UI.
Suppresses an annoying and repetitive warning about Microsoft's
`<ranges>` header not working properly in their C++20 implementation.
I finally got the tests running in Windows on appveyor.  Which revealed
a hanging test in Windows, for the nonblocking connection class.

The `pqxx::connecting` class tried to manage blocking/nonblocking states
on the connection.  But there does not seem to be any need: libpq does
all of that for us.
@jtv jtv changed the title Add appveyor.yml. Get Windows tests working & passing. Apr 10, 2022
@jtv jtv merged commit 12f26bf into master Apr 10, 2022
@jtv jtv deleted the appveyor-yml branch April 10, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant