src: allow unique_ptrs with custom deleter in memory tracker

PR-URL: nodejs#145 Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol · Dec 17, 2019 · 7bace89 · 7bace89
1 parent d3869f1
commit 7bace89
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/src/memory_tracker-inl.h b/src/memory_tracker-inl.h
@@ -109,16 +109,6 @@ void MemoryTracker::TrackField(const char* edge_name,
   TrackField(edge_name, value.get(), node_name);
 }
 
-template <typename T>
-void MemoryTracker::TrackField(const char* edge_name,
-                               const std::shared_ptr<T>& value,
-                               const char* node_name) {
-  if (value.get() == nullptr) {
-    return;
-  }
-  TrackField(edge_name, value.get(), node_name);
-}
-
 template <typename T, bool kIsWeak>
 void MemoryTracker::TrackField(const char* edge_name,
                                const BaseObjectPtrImpl<T, kIsWeak>& value,

diff --git a/src/memory_tracker.h b/src/memory_tracker.h
@@ -140,11 +140,6 @@ class MemoryTracker {
   inline void TrackField(const char* edge_name,
                          const std::unique_ptr<T, D>& value,
                          const char* node_name = nullptr);
-
-  template <typename T>
-  inline void TrackField(const char* edge_name,
-                         const std::shared_ptr<T>& value,
-                         const char* node_name = nullptr);
   template <typename T, bool kIsWeak>
   void TrackField(const char* edge_name,
                   const BaseObjectPtrImpl<T, kIsWeak>& value,