Add and fix noctx linter

juanfont · Nov 14, 2021 · d0ef850 · d0ef850
1 parent 1969802
commit d0ef850
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -30,7 +30,6 @@ linters:
     - stylecheck
     - wrapcheck
     - paralleltest
-    - noctx
     - nlreturn
     - ifshort
     - gomnd

diff --git a/derp.go b/derp.go
@@ -1,6 +1,7 @@
 package headscale
 
 import (
+	"context"
 	"encoding/json"
 	"io"
 	"io/ioutil"
@@ -30,10 +31,19 @@ func loadDERPMapFromPath(path string) (*tailcfg.DERPMap, error) {
 }
 
 func loadDERPMapFromURL(addr url.URL) (*tailcfg.DERPMap, error) {
+	ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
+	defer cancel()
+
+	req, err := http.NewRequestWithContext(ctx, "GET", addr.String(), nil)
+	if err != nil {
+		return nil, err
+	}
+
 	client := http.Client{
 		Timeout: 10 * time.Second,
 	}
-	resp, err := client.Get(addr.String())
+
+	resp, err := client.Do(req)
 	if err != nil {
 		return nil, err
 	}