Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired nodes error #1674

Closed
2 tasks
redstonekasi opened this issue Jan 3, 2024 · 1 comment · Fixed by #1692
Closed
2 tasks

Expired nodes error #1674

redstonekasi opened this issue Jan 3, 2024 · 1 comment · Fixed by #1692
Labels
bug Something isn't working
Milestone

Comments

@redstonekasi
Copy link

redstonekasi commented Jan 3, 2024

Bug description

When expired nodes are processed, an error occurs. It seems the node's expiry is still properly set regardless of the error.

2024-01-03T22:55:16+01:00 INF Client requested logout node=xxx
2024-01-03T22:55:16+01:00 TRC ../hscontrol/notifier/notifier.go:79 > acquiring lock to notify type=2
2024-01-03T22:55:16+01:00 TRC ../hscontrol/notifier/notifier.go:81 > releasing lock, finished notifing type=2
2024-01-03T22:55:16+01:00 TRC ../hscontrol/notifier/notifier.go:79 > acquiring lock to notify type=2
2024-01-03T22:55:16+01:00 TRC ../hscontrol/notifier/notifier.go:81 > releasing lock, finished notifing type=2
2024-01-03T22:55:16+01:00 INF ../hscontrol/auth.go:556 > Successfully logged out node=xxx
2024-01-03T23:00:30+01:00 ERR 🤮 Cannot expire node error="invalid value, should be pointer to struct or slice" name=xxx node=xxx

Environment

  • OS: Arch Linux
  • Headscale version: 0.23.0-alpha2
  • Tailscale version: 1.56.1
  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

To Reproduce

  1. Setup a headscale instance using the default config, then login.
  2. Log out using tailscale logout
@redstonekasi redstonekasi added the bug Something isn't working label Jan 3, 2024
@kradalby kradalby added this to the v0.23.0 milestone Jan 11, 2024
@leroycep
Copy link

I am also running into this bug. Same headscale and tailscale verison.

  • OS: NixOS 23.11

  • Headscale version: 0.23.0-alpha2

  • Tailscale version: 1.56.1

  • Headscale is behind a (reverse) proxy

  • Headscale runs in a container

fortitudepub added a commit to fortitudepub/headscale that referenced this issue Jan 19, 2024
Fixes juanfont#1674

Signed-off-by: fortitude.zhang <fortitude.zhang@gmail.com>
kradalby pushed a commit that referenced this issue Jan 21, 2024
Fixes #1674

Signed-off-by: fortitude.zhang <fortitude.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants