Align behaviour of dns_config.restricted_nameservers to tailscale #1162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161
Tailscale allows split DNS configuration without requiring global nameservers.
In addition, as per the docs:
In addition, as stated in the FAQ:This commit aligns headscale to tailscale by:
removing support fordns_config.domains
dns_config.restricted_nameservers
regardless of whether any global resolvers are configuredrestricted_nameservers
I realise "removing support for dns_config.domains" may be controversial as the tailscale client still supports search domains being defined separately, though it seems likely that this "undocumented" behaviour could (/should) be removed in future. Happy to adjust the change if required.EDIT: removed "removing support for dns_config.domains" as it is a breaking change.
If the changes look good, I'll update changelog etc.