Fix IPv6 in ACLs #1339
Merged
Fix IPv6 in ACLs #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
acl-tests-ipv6
branch
4 times, most recently
from
4c8c894
to
ee2c5e7
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
There was an issue which would not pass the opposite of the IPvX as filter rules to the tailscale client. This caused a rule referring to for example ipv4 to block ipv6 traffic for the client. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
acl-tests-ipv6
branch
from
ee2c5e7
to
5744487
Compare
juanfont
approved these changes
Apr 16, 2023
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
juanfont
pushed a commit
that referenced
this pull request
Apr 19, 2023
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com
This PR fixes a series of issues with ACLs and IPv6, were it could not be added at all, and then the underlying connection issues that was then exposed.
Updates #809