Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL refactor #1381

Merged
merged 13 commits into from
May 3, 2023
Merged

ACL refactor #1381

merged 13 commits into from
May 3, 2023

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Apr 26, 2023

General QoL improvements to the ACL code, naming, splitting up larger functions, some more tests at different layers.

Rewrite of the filtering of peers served as part of MapResponses, fixing #1372, undoing #1239, #1377, redoing #320.

Small contribution to laying the groundwork for improving SSH support.

acls.go Outdated Show resolved Hide resolved
machine.go Show resolved Hide resolved
@ventsislav-georgiev
Copy link

@kradalby Is there any chance of an image pushed to a public registry for trying out the changes directly?

@kradalby
Copy link
Collaborator Author

@ventsislav-georgiev sorry, its being continuously updated, so its not really feasible with our current release pipeline, we dont support or build docker officially. There is a binary attached to the build job on this PR.

@kradalby kradalby force-pushed the acl-refactor branch 4 times, most recently from 028ee4b to 9fd67dc Compare May 1, 2023 06:24
@loprima-l
Copy link
Contributor

Hi, about the potential ACL API, what is the current plan ?

@kradalby
Copy link
Collaborator Author

kradalby commented May 1, 2023

@loprima-l no plan, I have no intention of implementing an API for ACLs.

The current state is that some people want it, and have discussed how to do it, and we will accept an implementation that fits into the project. But it is currently not part of our priorities, and I do not think this will change for a long time.

@kradalby kradalby force-pushed the acl-refactor branch 5 times, most recently from 28843f7 to 917956b Compare May 2, 2023 09:34
kradalby added 11 commits May 2, 2023 11:51
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby marked this pull request as ready for review May 2, 2023 11:30
@kradalby kradalby requested a review from juanfont as a code owner May 2, 2023 11:30
@juanfont juanfont merged commit 735b185 into juanfont:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants