Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable Account Switching for Non-Ephemeral Devices on Logout #1528

Closed
wants to merge 1 commit into from

Conversation

vsychov
Copy link
Contributor

@vsychov vsychov commented Aug 15, 2023

Hello! I find myself saying this in almost every PR or ticket, but I'd like to take a moment to thank you once again for this fantastic product. I truly hope to see it thrive and evolve over time.

This PR addresses a user story and resolves a bug. Fixes: #1522 and #1310.

User Story:
As a user, I want the ability to switch between accounts that I'm logged into, either via OIDC or through an auth-key.

Existing Issues:

  • When logging in via OIDC as User A, then logging out and trying to log in as User B, there's a web interface error stating could not register machine.
  • If you log in using the auth-key for User A, log out, and then try to authenticate with the auth-key for User B, the authentication seems to work. However, you remain logged in as User A.

These scenarios are works for non-ephemeral devices. Ephemeral devices don't face this problem as they get removed upon logout. While these issues might be addressed in #1492, it got me thinking: Why not always remove devices on logout? What value do they have post-logout?

Hence, I'm suggesting this as either a temporary or permanent fix for the aforementioned issues.

@vsychov vsychov changed the title Delete all machines after logout, not only ephemeral Enhancement: Enable Account Switching for Non-Ephemeral Devices on Logout Aug 15, 2023
@kradalby
Copy link
Collaborator

Hi! as part of #1473, we have reorganised a lot of the code.

To clear PRs that needs to be rebased or redone, we are closing open PRs that will require significant code change to be merged.

In addition, the issue of the PR might in some cases have been fixed, change or no longer relevant, so it would be great if this is considered as well.

Thank you for your contribution!

If it is still relevant and the PR is reopened, we will aim at getting the changes into the next release after the reorg if accepted.

@kradalby kradalby closed this Sep 24, 2023
@axxonadmin
Copy link

it is relevant as of v0.23.0-alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in user switching during OIDC authentication
3 participants