Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test fail keep user.Clients from concurrent map writes #1544

Closed
wants to merge 1 commit into from
Closed

fix test fail keep user.Clients from concurrent map writes #1544

wants to merge 1 commit into from

Conversation

PatrickHuang888
Copy link
Contributor

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md
fatal error: concurrent map writes

goroutine 259 [running]:
github.com/juanfont/headscale/integration.(*EmbeddedDERPServerScenario).CreateTailscaleIsolatedNodesInUser.func1()

@kradalby
Copy link
Collaborator

kradalby commented Sep 7, 2023

Ah thanks, I think this makes sense, but after just skimming this, should it have its own lock?

@PatrickHuang888
Copy link
Contributor Author

Ah thanks, I think this makes sense, but after just skimming this, should it have its own lock?

yes, it can. but right now headscaleLock in senario just used in headscale creation, this just a test case init here, I think maybe use headscaleLock here simple enough and can work.

kradalby added a commit to kradalby/headscale that referenced this pull request Sep 10, 2023
@kradalby @PatrickHuang888
add lock around saving ts clients
187dbfe 
Closes juanfont#1544

Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby added a commit to kradalby/headscale that referenced this pull request Sep 11, 2023
@kradalby @PatrickHuang888
add lock around saving ts clients
915b440 
Closes juanfont#1544

Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby added a commit to kradalby/headscale that referenced this pull request Sep 11, 2023
@kradalby @PatrickHuang888
add lock around saving ts clients
f79cdc2 
Closes juanfont#1544

Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby added a commit to kradalby/headscale that referenced this pull request Sep 11, 2023
@kradalby @PatrickHuang888
add lock around saving ts clients
f7362c8 
Closes juanfont#1544

Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby added a commit to kradalby/headscale that referenced this pull request Sep 11, 2023
@kradalby @PatrickHuang888
add lock around saving ts clients
73fd5fc 
Closes juanfont#1544

Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby added a commit to kradalby/headscale that referenced this pull request Sep 11, 2023
@kradalby @PatrickHuang888
add lock around saving ts clients
b6d64e1 
Closes juanfont#1544

Co-Authored-By: Patrick Huang <huangxiaoman@gmail.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby closed this in 9ccf87c Sep 19, 2023
@PatrickHuang888 PatrickHuang888 deleted the hxmdev-upstream branch September 20, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

@kradalby kradalby Awaiting requested review from kradalby kradalby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickHuang888 @kradalby