validate policy against nodes, error if not valid #2089
Merged
Commits on Aug 30, 2024
-
validate policy against nodes, error if not valid
this commit aims to improve the feedback of "runtime" policy errors which would only manifest when the rules are compiled to filter rules with nodes. this change will in; file-based mode load the nodes from the db and try to compile the rules on start up and return an error if they would not work as intended. database-based mode prevent a new ACL being written to the database if it does not compile with the current set of node. Fixes juanfont#2073 Fixes juanfont#2044 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
-
ensure stderr can be used in err checks
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
-
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
-
add new integration test to ghaction
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
-
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.