Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make stream shutdown if self-node has been removed #2125

Merged
merged 3 commits into from
Sep 11, 2024
Merged

make stream shutdown if self-node has been removed #2125

merged 3 commits into from
Sep 11, 2024

Commits on Sep 11, 2024

  1. add shutdown that asserts if headscale had panics 

    Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
    @kradalby
    kradalby committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    921c65f View commit details
    Browse the repository at this point in the history

  2. add test case producing 2118 panic 

    Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
    @kradalby
    kradalby committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cac0ff3 View commit details
    Browse the repository at this point in the history

  3. make stream shutdown if self-node has been removed 

    Currently we will read the node from database, and since it is
deleted, the id might be set to nil. Keep the node around and
just shutdown, so it is cleanly removed from notifier.

Fixes juanfont#2118

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
    @kradalby
    kradalby committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    eb71f8a View commit details
    Browse the repository at this point in the history