Add -it to docker exec #2148

nblock · 2024-09-23T15:59:05Z

Some commands such as nodes delete require user interaction and they fail if -it is no supplied to docker exec. Use docker exec -it in documentation examples to also make them work in interactive commands.

See: #2147

have read the CONTRIBUTING.md file
raised a GitHub issue or discussed it on the projects chat beforehand
added unit tests
added integration tests
updated documentation if needed
updated CHANGELOG.md

Some commands such as `nodes delete` require user interaction and they fail if `-it` is no supplied to `docker exec`. Use `docker exec -it` in documentation examples to also make them work in interactive commands.

ohdearaugustin

Looks good, good point that some commands need an interactive shell.

Some commands such as `nodes delete` require user interaction and they fail if `-it` is no supplied to `docker exec`. Use `docker exec -it` in documentation examples to also make them work in interactive commands.

Add -it to docker exec

214ab40

Some commands such as `nodes delete` require user interaction and they fail if `-it` is no supplied to `docker exec`. Use `docker exec -it` in documentation examples to also make them work in interactive commands.

nblock requested a review from ohdearaugustin as a code owner September 23, 2024 15:59

ohdearaugustin approved these changes Sep 24, 2024

View reviewed changes

kradalby merged commit e367454 into juanfont:main Sep 25, 2024
121 checks passed

nblock deleted the docker-it branch September 25, 2024 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add -it to docker exec #2148

Add -it to docker exec #2148

nblock commented Sep 23, 2024

ohdearaugustin left a comment

Add -it to docker exec #2148

Add -it to docker exec #2148

Conversation

nblock commented Sep 23, 2024

ohdearaugustin left a comment

Choose a reason for hiding this comment