-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on the ACLs and bug fixing #320
Commits on Feb 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9b7d657 - Browse repository at this point
Copy the full SHA 9b7d657View commit details -
feat(machine): add ACLFilter if ACL's are enabled.
This commit change the default behaviour and remove the notion of namespaces between the hosts. It allows all namespaces to be only filtered by the ACLs. This behavior is closer to tailsnet.
Configuration menu - View commit details
-
Copy full SHA for e482dfe - Browse repository at this point
Copy the full SHA e482dfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9949b4 - Browse repository at this point
Copy the full SHA e9949b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb45138 - Browse repository at this point
Copy the full SHA fb45138View commit details -
feat(acl): update frequently the aclRules
This call should be done quite at each modification of a server resources like RequestTags. When a server changes it's tag we should rebuild the ACL rules. When a server is added to headscale we also should update the ACLRules.
Configuration menu - View commit details
-
Copy full SHA for 97eac3b - Browse repository at this point
Copy the full SHA 97eac3bView commit details -
feat(acls): rewrite functions to be testable
Rewrite some function to get rid of the dependency on Headscale object. This allows us to write succinct test that are more easy to review and implement. The improvements of the tests allowed to write the removal of the tagged hosts from the namespace as specified here: https://tailscale.com/kb/1068/acl-tags/
Configuration menu - View commit details
-
Copy full SHA for de59946 - Browse repository at this point
Copy the full SHA de59946View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b5ba9f - Browse repository at this point
Copy the full SHA 7b5ba9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for aceaba6 - Browse repository at this point
Copy the full SHA aceaba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cedbba - Browse repository at this point
Copy the full SHA 9cedbbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8c4c31 - Browse repository at this point
Copy the full SHA d8c4c31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f642ee - Browse repository at this point
Copy the full SHA 5f642eeView commit details -
chore(lint): ignore linting on test_expandalias
This is a false positive on the way the function is built. Small tests cases are all inside this functions, making it big.
Configuration menu - View commit details
-
Copy full SHA for f073d8f - Browse repository at this point
Copy the full SHA f073d8fView commit details
Commits on Feb 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 21df798 - Browse repository at this point
Copy the full SHA 21df798View commit details
Commits on Feb 20, 2022
-
Apply suggestions from code review on changelog
Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
Configuration menu - View commit details
-
Copy full SHA for 4f9ece1 - Browse repository at this point
Copy the full SHA 4f9ece1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d00251c - Browse repository at this point
Copy the full SHA d00251cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e167cc - Browse repository at this point
Copy the full SHA 5e167ccView commit details -
fix(machine): revert modifications
Using h.ListAllMachines also listed the current machine in the result. It's unnecessary (I don't know if it's harmful). Breaking the check with the `matchSourceAndDestinationWithRule` broke the tests. We have a specificity with the '*' destination that isn't symetrical. I need to think of a better way to do this. It too hard to read.
Configuration menu - View commit details
-
Copy full SHA for b3d0fb7 - Browse repository at this point
Copy the full SHA b3d0fb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5242025 - Browse repository at this point
Copy the full SHA 5242025View commit details
Commits on Feb 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ecb3ee6 - Browse repository at this point
Copy the full SHA ecb3ee6View commit details -
fix(machines): simplify complex if check
This should fix the performance issue with computation of `dst` variable. It's also easier to read now.
Configuration menu - View commit details
-
Copy full SHA for 960412a - Browse repository at this point
Copy the full SHA 960412aView commit details -
fix(machines): use ListAllMachines function
added a simple filter to remove the current node
Configuration menu - View commit details
-
Copy full SHA for 9c6ce02 - Browse repository at this point
Copy the full SHA 9c6ce02View commit details -
feat(machines): untie dependency with class for filter func
The dependency to the `headscale` struct makes tests harder to do. This change allow to easily add some tests for this quite sensible function.
Configuration menu - View commit details
-
Copy full SHA for f006860 - Browse repository at this point
Copy the full SHA f006860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ab6237 - Browse repository at this point
Copy the full SHA 5ab6237View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bbe005 - Browse repository at this point
Copy the full SHA 4bbe005View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25550f8 - Browse repository at this point
Copy the full SHA 25550f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 211fe40 - Browse repository at this point
Copy the full SHA 211fe40View commit details -
fix: add error checking in acl and poll
If aclPolicy is not defined, in updateAclPolicy, return an error.
Configuration menu - View commit details
-
Copy full SHA for 50af44b - Browse repository at this point
Copy the full SHA 50af44bView commit details -
Co-authored-by: Kristoffer Dalby <kradalby@kradalby.no>
Configuration menu - View commit details
-
Copy full SHA for baae266 - Browse repository at this point
Copy the full SHA baae266View commit details -
Configuration menu - View commit details
-
Copy full SHA for 650108c - Browse repository at this point
Copy the full SHA 650108cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d971f0f - Browse repository at this point
Copy the full SHA d971f0fView commit details