-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework hostname handling #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a good PR in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is is a go!
Ok for me too ! |
This commit makes isOutdated validate a nodes necessity to update against all namespaces, and not just the nodes own namespace (which made more sense before). getLastStateChange is now uses the passed namespaces as a filter, meaning that not requesting any namespace will give you the total last updated state. In addition, the sync.Map is exchanged for a variant that uses generics which allows us to remove some casting logic.
@@ -17,6 +17,8 @@ | |||
- Add the ability to rename a nodes name [#560](https://github.com/juanfont/headscale/pull/560) | |||
- Node DNS names are now unique, a random suffix will be added when a node joins | |||
- This change contains database changes, remember to **backup** your database before upgrading | |||
- Add option to enable/disable logtail (Tailscale's logging infrastructure) [#596](https://github.com/juanfont/headscale/pull/596) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
This PR builds on the work of @bravechamp, and implements the suggested changes from the comments.
It replaces #498
Changes:
Machines can have nicknamesMachines now has a separate name used for DNS (settable by users)nodes list
outputnodes rename
to rename nodes