Rework hostname handling #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restanrm
reviewed
Apr 25, 2022
restanrm
reviewed
Apr 25, 2022
|
Ok for me too ! |
This commit makes isOutdated validate a nodes necessity to update against all namespaces, and not just the nodes own namespace (which made more sense before). getLastStateChange is now uses the passed namespaces as a filter, meaning that not requesting any namespace will give you the total last updated state. In addition, the sync.Map is exchanged for a variant that uses generics which allows us to remove some casting logic.
juanfont
reviewed
May 31, 2022
| @@ -17,6 +17,8 @@ | |||
| - Add the ability to rename a nodes name [#560](https://github.com/juanfont/headscale/pull/560) | |||
| - Node DNS names are now unique, a random suffix will be added when a node joins | |||
| - This change contains database changes, remember to **backup** your database before upgrading | |||
| - Add option to enable/disable logtail (Tailscale's logging infrastructure) [#596](https://github.com/juanfont/headscale/pull/596) | |||
juanfont
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work of @bravechamp, and implements the suggested changes from the comments.
It replaces #498
Changes:
Machines can have nicknamesMachines now has a separate name used for DNS (settable by users)nodes listoutputnodes renameto rename nodes