Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obtuse "ephemeral_node_inactivity_timeout" error #639

Merged
merged 6 commits into from
Jun 12, 2022
Merged

Fix obtuse "ephemeral_node_inactivity_timeout" error #639

merged 6 commits into from
Jun 12, 2022

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Jun 12, 2022 •
edited
Loading

This fixes #251

This PR will:

  • Move the configuration check for ephemeral_node_inactivity_timeout to where it should be
  • Set a default for ephemeral_node_inactivity_timeout
  • Add a warn if configuration could not be found.
  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@kradalby kradalby changed the title Fix obtuse error: Fix obtuse "ephemeral_node_inactivity_timeout" error Jun 12, 2022
@kradalby kradalby marked this pull request as ready for review June 12, 2022 13:33
@kradalby kradalby requested a review from juanfont as a code owner June 12, 2022 13:33
juanfont
juanfont previously approved these changes Jun 12, 2022
View reviewed changes
@kradalby kradalby merged commit 8918156 into juanfont:main Jun 12, 2022
@kradalby kradalby deleted the ephemeral-error-msg branch June 12, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont juanfont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create namespace error : ephemeral_node_inactivity_timeout
2 participants
@kradalby @juanfont