Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for TLS with Postgres #745

Merged
merged 7 commits into from
Aug 18, 2022
Merged

feat: add support for TLS with Postgres #745

merged 7 commits into from
Aug 18, 2022

Conversation

Zk2u
Copy link
Contributor

@Zk2u Zk2u commented Aug 16, 2022 •
edited
Loading

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Fixes #741

@Zk2u Zk2u marked this pull request as ready for review August 16, 2022 08:09
juanfont
juanfont previously approved these changes Aug 16, 2022
View reviewed changes
@juanfont juanfont self-requested a review August 16, 2022 11:06
@juanfont juanfont dismissed their stale review August 16, 2022 11:06

tests not passing

juanfont
juanfont approved these changes Aug 18, 2022
View reviewed changes
Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@juanfont juanfont merged commit 2dd615a into juanfont:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont juanfont approved these changes

@kradalby kradalby Awaiting requested review from kradalby kradalby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Postgres TLS
2 participants
@Zk2u @juanfont