Fix prefix length comparison bug in AutoApprovers route evaluation #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsujamin
force-pushed
the
autoapprovers-prefix-approval-bug
branch
from
6e2b6f8
to
ef5fe7f
Compare
6 tasks
samcday
reviewed
Oct 15, 2022
| @@ -125,7 +125,7 @@ func (autoApprovers *AutoApprovers) GetRouteApprovers( | |||
| return nil, err | |||
| } | |||
|
|
|||
| if autoApprovedPrefix.Bits() >= prefix.Bits() && | |||
| if prefix.Bits() >= autoApprovedPrefix.Bits() && | |||
There was a problem hiding this comment.
Is this check even necessary, given the Contains check below?
There was a problem hiding this comment.
Never mind I see, Contains operates on a single IP, hence the need for this check.
There was a problem hiding this comment.
ah yeah that makes sense, I'd forgotten entirely and it's pretty late here 😅
samcday
previously approved these changes
Oct 15, 2022
|
+1, I've been soaking this change in my personal tailnet for a week now, LGTM 👍 |
kradalby
previously approved these changes
Nov 1, 2022
kradalby
approved these changes
Nov 1, 2022
|
ty! my mistakes are undone 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug raised by @samcday in #763 where a subprefix (
10.0.1.0/24) of an autoApproved route (10.0.0.0/8) wasn't being approved due to an incorrect comparison of their prefix lengths. The corresponding unit test has been modified to capture this regression.