-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support serde skip_serializing
#438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but there is a test missing, and docs as well.
Docs should be updated here: https://github.com/juhaku/utoipa/blob/master/utoipa-gen/src/lib.rs#L179
And here:
https://github.com/juhaku/utoipa/blob/master/utoipa-gen/src/lib.rs#L1569
I suppose this skip_serializing
should work in both IntoParams
and in ToSchema
I couldn't find where the tests are for the original |
Sure here is the example test for skip for utoipa/utoipa-gen/tests/schema_derive_test.rs Lines 2645 to 2682 in 13a3aae
Seems like the skip support is not implemented for So just creating a test for for |
Also instead of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good, since you added the skip_serializing
to the same test, we can remove the assert_value!
No description provided.