Add test for date types in actix params #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
actix-date-params-test
branch
from
1c128d1 to
cde0eda
Compare
jayvdb
force-pushed
the
actix-date-params-test
branch
from
cde0eda to
d4434d1
Compare
jayvdb
commented
Sep 10, 2023
| "[1].required" = r#"true"#, "Parameter required" | ||
| "[1].deprecated" = r#"null"#, "Parameter deprecated" | ||
| "[1].schema.type" = r#""string""#, "Parameter schema type" | ||
| "[1].schema.format" = r#"null"#, "Parameter schema format" |
There was a problem hiding this comment.
note this is probably the problem described in #693 - format = DateTime does not override the rust arg being of type String.
I am not sure if this is expected / desirable behaviour.
There was a problem hiding this comment.
Right, I believe this is at least one of the inconsistencies between the without actix_web or other framework and with.
I don't remember what was the original thought when implementing this but now I could consider this as undesired behavior. I reckon the order of recognizing parameters should first come from fn arguments if framework is supported and later they should be overridable with manual params(...) definition.
jayvdb
force-pushed
the
actix-date-params-test
branch
from
d4434d1 to
56434c0
Compare
jayvdb
force-pushed
the
actix-date-params-test
branch
from
56434c0 to
0117631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #693