Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Session.user_id should be optional #298

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Apr 26, 2024


🚀 This description was created by Ellipsis for commit ff47611

Summary:

This PR makes the user_id field in the Session model optional and updates the Python and TypeScript SDKs to reflect this change.

Key points:

  • Made user_id field in Session model optional.
  • Updated Session model in sdks/python/julep/api/types/session.py and sdks/ts/src/api/models/Session.ts.
  • Removed user_id from required fields in openapi.yaml and mock_openapi.yaml.
  • Bumped SDK version to 0.3.1 in sdks/python/pyproject.toml and sdks/ts/package.json.

Generated with ❤️ by ellipsis.dev

Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested.

  • Reviewed the entire pull request up to ff47611
  • Looked at 135 lines of code in 9 files
  • Took 1 minute and 5 seconds to review
More info
  • Skipped 2 files when reviewing.
  • Skipped posting 0 additional comments because they didn't meet confidence threshold of 50%.

Workflow ID: wflow_Wqu95t0Muaols3b0


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.

sdks/ts/src/api/schemas/$Session.ts Show resolved Hide resolved
@creatorrr creatorrr merged commit b521a9c into dev Apr 26, 2024
4 checks passed
@creatorrr creatorrr deleted the x/fix-session-user-id-optional branch April 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant