Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update SDKs #333

Merged
merged 1 commit into from
May 17, 2024
Merged

chore: Update SDKs #333

merged 1 commit into from
May 17, 2024

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented May 16, 2024

🚀 This description was created by Ellipsis for commit 3cae337

Summary:

This PR updates SDKs across Python and TypeScript, modifying client methods, configurations, and type definitions to align with recent API changes, focusing on enhanced session management and structured document handling, including new handling for document content and IDs.

Key points:

  • Updated SDKs for Python and TypeScript.
  • Modified API client methods and configurations.
  • Adjusted model schemas and type definitions.
  • Reflected changes in session management, document handling, and agent interactions.
  • Updated models and schemas to reflect changes in document content handling and session responses.
  • Introduced new types for document content and IDs.
  • Introduced handling for document content as either string or list of strings.
  • Added new type DocIds for managing document identifiers.
  • Adjusted session and chat response handling to include document IDs.
  • Enhanced session management and structured document handling.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

sweep-ai bot commented May 16, 2024

Sweep: PR Review

Sweep is currently reviewing your pr...

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 46cce17 in 3 minutes and 26 seconds

More details
  • Looked at 1230 lines of code in 25 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/python/julep/api/types/chat_input_data_tool_choice.py:9
  • Draft comment:
    The union type ChatInputDataToolChoice is defined to include ToolChoiceOption and NamedToolChoice, but it seems like it should also include NamedToolChoiceFunction based on the import statement. This might be an oversight or an incomplete implementation. Please verify if NamedToolChoiceFunction should be part of this union type.
ChatInputDataToolChoice = typing.Union[ToolChoiceOption, NamedToolChoice, NamedToolChoiceFunction]
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_r3A5WKGJVM0bhSNR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 96ae274 in 2 minutes and 40 seconds

More details
  • Looked at 1198 lines of code in 24 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/python/julep/api/types/doc.py:20
  • Draft comment:
    The update to allow Doc.content to be either a string or a list of strings is correctly implemented here and matches the changes in the TypeScript SDK as well. This ensures consistency across different SDKs for handling document content flexibility.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR updates the SDKs for Python and TypeScript, including changes to the handling of documents. The Doc model now supports content being either a string or a list of strings, which is reflected in both Python and TypeScript SDKs. This change is consistent across the codebase, and the PR author has updated the relevant models, types, and schemas to support this new structure.

Workflow ID: wflow_BFd4VyVRF4uUjBeP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 035e7f9 in 2 minutes and 25 seconds

More details
  • Looked at 3100 lines of code in 45 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/python/julep/api/types/create_doc.py:20
  • Draft comment:
    The CreateDoc model now correctly uses CreateDocContent for the content field to support both string and list of strings formats. This change aligns with the updated document handling requirements.
content: CreateDocContent = pydantic.Field(description="Information content")
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The Python SDK has been updated to reflect changes in the handling of document content, where the content can now be either a string or a list of strings. This change is reflected in the new CreateDocContent and DocContent types, which are used in the CreateDoc and Doc models respectively. This update is consistent across the SDK, ensuring that the document content handling is flexible to accommodate different formats.

Workflow ID: wflow_CgFDGDR5p0cWUlyX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on fcaf588 in 5 minutes and 36 seconds

More details
  • Looked at 11146 lines of code in 187 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/ts/src/api/models/Doc.ts:13
  • Draft comment:
    Ensure that all parts of the system that interact with the content field of Doc and CreateDoc models are updated to handle both string and array types. This change might require updates in the handling, validation, and storage of document content.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_afeHiBDAps2uuw9C


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3cae337 in 3 minutes and 54 seconds

More details
  • Looked at 11146 lines of code in 187 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. sdks/ts/src/api/models/Doc.ts:13
  • Draft comment:
    The update to allow content to be either a string or an array of strings enhances flexibility and aligns with the PR's goals. Ensure all dependent functionalities are updated to handle both types correctly.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The TypeScript SDK has updated the handling of document content to allow it to be either a string or an array of strings. This change is reflected in the models and schemas for both Doc and CreateDoc. This update aligns with the PR description about handling document content as either a string or a list of strings, enhancing flexibility in document content management.

Workflow ID: wflow_8G7UcyifUn61zMrw


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit 03079a2 into dev May 17, 2024
11 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/sdk-update branch May 17, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant