feat: Implement filtering by metadata

[whiterabbit1983]

🚀 This description was created by Ellipsis for commit 3a6bbd2

Summary:

Enhanced document retrieval functionality in the agents and users API by implementing metadata filtering.

Key points:

• Implemented metadata filtering for document retrieval in the agents and users API
• Added metadata_filter parameter to list_docs_snippets_by_owner_query in /agents-api/agents_api/models/docs/list_docs.py
• Updated list_docs endpoints in /agents-api/agents_api/routers/agents/routers.py and /agents-api/agents_api/routers/users/routers.py to accept metadata_filter from requests
• Implemented JSON parsing and error handling for metadata_filter in the routers

---

Generated with ❤️ by ellipsis.dev

[sweep-ai]

Sweep: PR Review

agents-api/agents_api/models/docs/list_docs.py

The changes introduce a new metadata_filter parameter to the list_docs_snippets_by_owner_query function, allowing for metadata-based filtering of documents.

Sweep Found These Issues

• The use of a mutable default argument metadata_filter: dict[str, Any] = {} can lead to unexpected behavior if the dictionary is modified.

julep/agents-api/agents_api/models/docs/list_docs.py

Line 39 in 8a1053a

metadata_filter: dict[str, Any] = {},


View Diff
• The constructed metadata_filter_str does not handle cases where the metadata_filter dictionary is empty, potentially leading to syntax errors in the query.

julep/agents-api/agents_api/models/docs/list_docs.py

Lines 43 to 48 in 8a1053a

	metadata_filter_str = ", ".join(
	[
	f"metadata->{json.dumps(k)} == {json.dumps(v)}"
	for k, v in metadata_filter.items()
	]
	)


View Diff

---

agents-api/agents_api/routers/agents/routers.py

The changes allow the metadata_filter parameter to be used for filtering documents and remove the check for the agent's existence before querying documents.

Sweep Found These Issues

• The removal of the check to ensure the agent exists before querying for documents could lead to querying with an invalid agent_id, potentially causing unexpected errors or behavior.

julep/agents-api/agents_api/routers/agents/routers.py

Line 9 in 8a1053a

import pandas as pd


View Diff

---

agents-api/agents_api/routers/users/routers.py

The change removes the HTTP 501 Not Implemented error for metadata_filter and updates the function call to support metadata filtering.

Sweep Found These Issues

• The removal of the HTTP 501 Not Implemented error handling for metadata_filter without ensuring that list_docs_snippets_by_owner_query can handle the filter correctly may lead to unexpected behavior or errors if the filter is not properly implemented.

julep/agents-api/agents_api/routers/users/routers.py

Lines 288 to 297 in 8a1053a

	detail="metadata_filter is not a valid JSON",
	)
	if not len(list(ensure_owner_exists_query("user", user_id).iterrows())):
	raise UserNotFoundError("", user_id)
	resp = list_docs_snippets_by_owner_query(
	owner_type="user",
	owner_id=user_id,
	metadata_filter=metadata_filter,


View Diff

---

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 8a1053a in 1 minute and 6 seconds

More details

• Looked at 93 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_rLMNgdq9vJ4GSMEa

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[creatorrr]

Lgtm

[ellipsis-dev]

❌ Changes requested. Incremental review on 3a6bbd2 in 1 minute and 56 seconds

More details

• Looked at 34 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_G5pE8zbnZhnNkZxz

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.