Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #514

Merged
merged 13 commits into from
Sep 22, 2024
Merged

dev -> main #514

merged 13 commits into from
Sep 22, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Sep 22, 2024

Important

Major update integrating litellm for embeddings, refining environment configurations, enhancing API endpoints, and updating Docker setups across services.

  • Embedding Service Integration:
    • Replaced embed client with litellm in embed_docs.py, gather_messages.py, and embed.py.
    • Removed embed.py and updated litellm.py to include aembedding() function.
  • Environment Configuration:
    • Removed EMBEDDING_SERVICE_BASE from .env.example and env.py.
    • Added embedding_dimensions to env.py.
  • Docker and Deployment:
    • Updated docker-compose.yml files across multiple services to refine service dependencies and environment variables.
    • Added restart: unless-stopped to several services for better resilience.
  • API Enhancements:
    • Updated API endpoints for agents, sessions, tasks, and users in routers directory.
    • Added or modified endpoints for creating, updating, deleting, and listing resources.
  • Testing:
    • Updated test_chat_routes.py to reflect changes in embedding service and API endpoints.
  • Miscellaneous:
    • Updated pyproject.toml to bump litellm version to ^1.46.7.
    • Added .gitignore for certificate files in scheduler/cert/.

This description was created by Ellipsis for 8b2bd54. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8b2bd54 in 36 seconds

More details
  • Looked at 1422 lines of code in 63 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/clients/litellm.py:65
  • Draft comment:
    Avoid using input as a variable name since it's a built-in function in Python. Consider renaming it to something like input_data.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code in agents-api/agents_api/clients/litellm.py has a potential issue with the variable name input which is a built-in function in Python. It's better to avoid using built-in names for variables to prevent any unexpected behavior.

Workflow ID: wflow_bauFFgcqaG3asAfg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit c33bbea into main Sep 22, 2024
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants