chore: restore behavior that lists files that need formatting #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
reviewed
Jun 18, 2024
mortenpi
reviewed
Jun 18, 2024
|
I think I addressed all the comments... |
|
Huh, guess I clicked "close" instead of "comment" :) |
|
@hyrodium how does this look to you? |
mortenpi
reviewed
Jun 21, 2024
mortenpi
reviewed
Jun 21, 2024
|
@domluna Sorry, I don't have time to review this PR at least for a few days. We already have some reviews, so merging when other reviewers approve seems okay! |
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
mortenpi
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
LGTM now! All cases worked perfectly with branch as far as I can tell:
Success: https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/9611403801/job/26509891661
Reviewdog: https://github.com/JuliaComputing/JuliaHub.jl/actions/runs/9611588130/job/26510453352?pr=61
|
Good to merge then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back in the list of files that need formatting. At least the action we used to use did that.
This way, if reviewdog doesn't run, you can at least see the files that need formatting.