Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control of --check-bounds command option #46

Merged
merged 17 commits into from
Dec 22, 2021
Merged

Allow control of --check-bounds command option #46

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
53c01e3
allow control of bounds-check command option
IanButterworth Jul 6, 2021
17b98dd
tryfix
IanButterworth Jul 6, 2021
b650dee
Update action.yml
IanButterworth Jul 8, 2021
8ec6545
Update action.yml
IanButterworth Jul 8, 2021
377a818
tryfix
IanButterworth Jul 10, 2021
aa1ae13
alternative bash if else approach
IanButterworth Jul 10, 2021
9c0cb0d
another approach
IanButterworth Jul 11, 2021
ca36417
use julia_args approach
IanButterworth Jul 13, 2021
c12547f
add julia_args to kwargs func
IanButterworth Jul 13, 2021
41251bb
fix
IanButterworth Jul 13, 2021
513b54d
move julia_args to before return
IanButterworth Jul 13, 2021
26bfe8e
guard against v1.0
IanButterworth Jul 13, 2021
f2e7be0
add warning
IanButterworth Jul 13, 2021
8442719
Update kwargs.jl
IanButterworth Jul 13, 2021
8603d27
handle the default state and improve error message
IanButterworth Jul 20, 2021
6c2b827
Update kwargs.jl
IanButterworth Dec 14, 2021
f281faf
Update kwargs.jl
IanButterworth Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ branding:
color: 'gray-dark'

inputs:
check_bounds:
description: 'Value determining which bounds checking setting to use. Options: yes | no | auto. Default value: yes.'
default: 'yes'
coverage:
description: 'Value determining whether to test with coverage or not. Options: true | false. Default value: true.'
default: 'true'
Expand Down Expand Up @@ -48,7 +51,7 @@ runs:
JULIA_PKG_SERVER: ""
- run: |
# The Julia command that will be executed
julia_cmd=( julia --check-bounds=yes --color=yes --depwarn=${{ inputs.depwarn }} --inline=${{ inputs.inline }} --project=${{ inputs.project }} -e 'import Pkg;include(joinpath(ENV["GITHUB_ACTION_PATH"], "kwargs.jl"));kwargs = Kwargs.kwargs(;coverage = :(${{ inputs.coverage }}),force_latest_compatible_version = :(${{ inputs.force_latest_compatible_version }}),);Pkg.test(; kwargs...)' )
julia_cmd=( julia --color=yes --depwarn=${{ inputs.depwarn }} --inline=${{ inputs.inline }} --project=${{ inputs.project }} -e 'import Pkg;include(joinpath(ENV["GITHUB_ACTION_PATH"], "kwargs.jl"));kwargs = Kwargs.kwargs(;coverage = :(${{ inputs.coverage }}),force_latest_compatible_version = :(${{ inputs.force_latest_compatible_version }}), julia_args = ["--check-bounds=${{ inputs.check_bounds }}"]);Pkg.test(; kwargs...)' )

# Add the prefix in front of the command if there is one
prefix="${{ inputs.prefix }}"
Expand Down
11 changes: 10 additions & 1 deletion kwargs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,23 @@ import Pkg
include(joinpath(@__DIR__, "autodetect-dependabot.jl"))

function kwargs(; coverage::Bool,
force_latest_compatible_version::Union{Bool, Symbol})
force_latest_compatible_version::Union{Bool, Symbol},
julia_args::AbstractVector{<:AbstractString}}=String[])
IanButterworth marked this conversation as resolved.
Show resolved Hide resolved
if !(force_latest_compatible_version isa Bool) && (force_latest_compatible_version != :auto)
throw(ArgumentError("Invalid value for force_latest_compatible_version: $(force_latest_compatible_version)"))
end

kwargs_dict = Dict{Symbol, Any}()
kwargs_dict[:coverage] = coverage

if VERSION >= v"1.6.0"
kwargs_dict[:julia_args] = julia_args
elseif julia_args == ["--check-bounds=yes"]
# silently don't add this default julia_args value as < 1.6 doesn't support julia_args, but it's the default state
else
println("::warning::The Pkg.test bounds checking behavior cannot be changed before Julia 1.6. VERSION=$VERSION, julia_args=$julia_args")
end

if VERSION < v"1.7.0-" || !hasmethod(Pkg.Operations.test, Tuple{Pkg.Types.Context, Vector{Pkg.Types.PackageSpec}}, (:force_latest_compatible_version,))
(force_latest_compatible_version != :auto) && @warn("The `force_latest_compatible_version` option requires at least Julia 1.7", VERSION, force_latest_compatible_version)
return kwargs_dict
Expand Down