extract julia directly to tool path to maintain mtimes

.github/workflows/common-tests.jl → .github/scripts/common-tests.jl

@@ -5,7 +5,7 @@ if VERSION >= v"1.7.0" # pkgdir was introduced here, and before then mtime wasn'
     using Pkg
     src = pkgdir(Pkg, "src", "Pkg.jl")
     # mtime is when it's compressed, ctime is when the file is extracted
-    if !<(mtime(src), ctime(src))
+    if mtime(src) >= ctime(src)
         error("source mtime ($(mtime(src))) is not earlier than ctime ($(ctime(src)))")
     end
 end

.github/workflows/example-builds-defaultarch.yml

@@ -45,4 +45,4 @@ jobs:
       - run: julia --version
       - run: julia --compile=min -O0 -e 'import InteractiveUtils; InteractiveUtils.versioninfo()'
       - name: "Check that the correct julia is used and that archive mtimes are maintained"
-        run: julia --startup-file=no --color=yes ./.github/workflows/common-tests.jl
+        run: julia --startup-file=no --color=yes ./.github/scripts/common-tests.jl

.github/workflows/example-builds-nightly-defaultarch.yml

@@ -43,4 +43,4 @@ jobs:
       - run: julia --version
       - run: julia --compile=min -O0 -e 'import InteractiveUtils; InteractiveUtils.versioninfo()'
       - name: "Check that the correct julia is used and that archive mtimes are maintained"
-        run: julia --startup-file=no --color=yes ./.github/workflows/common-tests.jl
+        run: julia --startup-file=no --color=yes ./.github/scripts/common-tests.jl

.github/workflows/example-builds-nightly.yml

@@ -51,4 +51,4 @@ jobs:
       - run: julia --version
       - run: julia --compile=min -O0 -e 'import InteractiveUtils; InteractiveUtils.versioninfo()'
       - name: "Check that the correct julia is used and that archive mtimes are maintained"
-        run: julia --startup-file=no --color=yes ./.github/workflows/common-tests.jl
+        run: julia --startup-file=no --color=yes ./.github/scripts/common-tests.jl

.github/workflows/example-builds.yml

@@ -51,4 +51,4 @@ jobs:
       - run: julia --version
       - run: julia --compile=min -O0 -e 'import InteractiveUtils; InteractiveUtils.versioninfo()'
       - name: "Check that the correct julia is used and that archive mtimes are maintained"
-        run: julia --startup-file=no --color=yes ./.github/workflows/common-tests.jl
+        run: julia --startup-file=no --color=yes ./.github/scripts/common-tests.jl

src/setup-julia.ts

@@ -72,18 +72,18 @@ async function run() {
 
             // https://github.com/julia-actions/setup-julia/pull/196
             // we want julia to be installed with unmodified file mtimes
-            // but tc.cacheDir uses `cp` which destroys mtime
+            // but `tc.cacheDir` uses `cp` internally which destroys mtime
             // and `tc` provides no API to get the tool directory alone
-            // so hack it by installing a dummy julia file then use the path it returns
+            // so hack it by installing a empty directory then use the path it returns
             // and extract the archives directly to that location
-            const tempDummyDir = fs.mkdtempSync('julia-dummy-')
-            juliaPath = await tc.cacheDir(tempDummyDir, 'julia', version, arch)
+            const emptyDir = fs.mkdtempSync('empty')
+            juliaPath = await tc.cacheDir(emptyDir, 'julia', version, arch)
             await installer.installJulia(juliaPath, versionInfo, version, arch)
 
             core.debug(`added Julia to cache: ${juliaPath}`)
 
-            // Remove temporary dummy dir
-            fs.rmSync(tempDummyDir, {recursive: true})
+            // Remove empty dir. Has to be recursive as it's a dir, even though it's empty
+            fs.rmSync(emptyDir, { recursive: true })
         } else {
             core.debug(`using cached version of Julia: ${juliaPath}`)
         }