Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlline should support vi mode for navigating between commands and within the commandline (similar to set -o vi in the shell) #60

Closed
shyamsfo opened this issue Mar 15, 2017 · 8 comments

Comments

@shyamsfo
Copy link

No description provided.

@julianhyde
Copy link
Owner

Fixed in bf495f9, PR #155. Thanks @snuyanzin!

@elnerko
Copy link

elnerko commented Nov 13, 2018

Does it really work? Sqlline does not work in vi-mode for me, it doesn't respect .inputrc settings.
I think I tried everything listed here with no luck:
https://github.com/jline/jline2/wiki/Using-JLine
(it's for v2, but I guess it should apply to v3 of JLine)

@julianhyde
Copy link
Owner

I don't know. @snuyanzin have you managed to get vi mode working?

@snuyanzin
Copy link
Collaborator

Thank you for highlighting this.
Currently .inputrc is not supported by sqlline, moreover it was removed from jline3 and then added again in a little different way jline/jline3#230.

Good point to have it supported.

@snuyanzin
Copy link
Collaborator

just filed a new issue for its support

@snuyanzin
Copy link
Collaborator

snuyanzin commented Nov 14, 2018

@rkoelner, may be you will be interested in it.
I submitted PR #198 which allows to switch between emacs/vi editing mode. Yes it is still does not support .inputrc files but it is possible both to switch mode while running of sqlline and to specify the mode at start like ./sqlline --mode=vi

@elnerko
Copy link

elnerko commented Nov 14, 2018

Amazing, works perfect! Thank you a ton, sir!
A solid JDBC shell client was the the only tool missing missing in my zsh+tmux+repls setup. Now, I'll be spending much more time with sqlline, and encourage others to do so.

@julianhyde
Copy link
Owner

Fixed in 68bf5df, PR #198. Thanks @snuyanzin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants