-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Jline3 #115
Migration to Jline3 #115
Conversation
67e67c8
to
93221f6
Compare
486b4f7
to
ee72e9a
Compare
1. Required jdk -> 1.8+ 2. Required jline -> 3.9.0 (also included jna, jansi artifacts required for Windows) 3. Multiline mode if quotes are not closed or a line not finished with a semicolon (in case of non-command or !sql, !all). As a hint a missing symbol is mentioned in prompt. And now becomes possible to get the whole multiline command from the history via up/down. SqlLineParser and SqlLineParserTest classes. 4. Usage of internal jline history 5. Test for !manual is switched off as it required currently not supported interactive mode in tests. (Also some comments below about these last bullets)
3f59858
to
5f61e22
Compare
1. Rebased to sqlline 1.15.0 2. !manual test fixed
f2d06d2
to
a99e977
Compare
|
Added padded prompt in a similar way it is before moving to jline3 for instance
|
Added additional tests for !rerun, !/ commands based on generated history file
@julianhyde could I ask you to have a look and merge if it looks ok from your side or put some comments otherwise. |
@snuyanzin I know you fixes for #154 and #155 in another branch. Can you please rebase on the new master? |
The PR is intended to move to jline3, jdk8
What is done
less
for!manual
in case of not Windows. In case of Windows usage of old silly pager as currentless
implementation fails on Windows Less fails On Windows with java.util.regex.PatternSyntaxException jline/jline3#304Test for!manual
is switched off as it required currently not supported interactive mode in tests. (Also some comments below about these last bullets)Also as a 'side effect'
vi
-like keymap binding is available now,I guess something similar was requested in #60
Also there have come many other jline3 features
What is under question
1. About ways to test!manual
. Currently I have the next in my mind- As the test were intended to check if manual.txt present or not (the original issue #49 ) we could do exactly this test- Test with timeout which could help with exit from interactive mode2. Jline3 uses timestamps in their history files. The problem could be if a user of jline2-based sqlline will try to use jline3-based. Here there are several ways to resolve the issue