Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"!record <logfile>" as an external command line option (e.g. "--log <logfile>") #67

Closed
beaumex opened this issue Sep 19, 2017 · 4 comments

Comments

@beaumex
Copy link

beaumex commented Sep 19, 2017

First things first : thank you for maintaining that extraordinary tool ; I searched a lot to find this graal in a very heterogeneous db environment !

I mainly use (as of today) sqlline 1.3 as a ddl deployment tool but I still have to dance a little in order to wrap those committed scripts I have to deploy in order to get the "!record" statements in.

Provided the same functionality as a command line option, I could leave scripts unaltered
(In fact, I build an intermediary launcher as a sqlline commands script including !record and !run on the original ddl file)

Thanks

@julianhyde
Copy link
Owner

You're welcome! I'm very pleased that sqlline is useful to you.

A --log <logfile> command line option totally makes sense. I may get to it someday, but I would be grateful to receive e pull request.

@beaumex
Copy link
Author

beaumex commented Sep 21, 2017 via email

@snuyanzin
Copy link
Collaborator

Should the issue be closed or is there anything not implemented yet?
cc @julianhyde

@julianhyde
Copy link
Owner

Fixed in f62bb74, PR #92. Thanks @snuyanzin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants