Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLLINE-186] Added setting TerminalBuilder.PROP_DUMB before and afte… #212

Closed
wants to merge 21 commits into from

Conversation

snuyanzin
Copy link
Collaborator

The PR sets TerminalBuilder.PROP_DUMB property before and after CompletionTest that makes stdout free from errors mentioned in #186 (comment)

snuyanzin and others added 8 commits November 27, 2018 16:38
…mpmletion for properties values like outputformat or boolean properties
…mpmletion for properties values like outputformat or boolean properties
…or copmletion

Correct method sqlline.SqlLineOpts#optionCompleters to generate org.jline.builtins.Completers.RegexCompleter for
!set command based on (in decreasing order of priority)
1. Customizations
2. Available values defined in BuiltInProperty
3. Type of property. Currently there is completion only for boolean type with completion values from sqlline.SqlLineProperty#BOOLEAN_VALUES

Added javadoc for sqlline.SqlLineOpts#optionCompleters
Use Application#getName2HighlightStyle for color scheme available values
…mpletion for properties values like outputformat or boolean properties
@snuyanzin snuyanzin force-pushed the scratch_autocompletion branch from cb92fdc to f1ff7ca Compare November 27, 2018 13:42
snuyanzin and others added 13 commits November 27, 2018 16:47
…ss susceptible to errors in underlying JDBC driver

Wrapper uses reflection, and handles method-not-supported exceptions.
In future it could perhaps handle other exceptions, and do caching.

Add a test emulating hive behaviour with method not supported.

Add "strictJdbc" property to mark whether we should use default values
when hitting not-supported/not-implemented methods of DatabaseMetaData.
…ject

Use getDeclaredMethods rather than getMethods, and only show public
non-static methods.
Correct how we detect whether an input line is SQL, and thereby fix
highlighting. Add more tests for highlighting in !sql, !all commands.
Add release notes, and update version number.
Correct release date in release notes.
…mpmletion for properties values like outputformat or boolean properties
…or copmletion

Correct method sqlline.SqlLineOpts#optionCompleters to generate org.jline.builtins.Completers.RegexCompleter for
!set command based on (in decreasing order of priority)
1. Customizations
2. Available values defined in BuiltInProperty
3. Type of property. Currently there is completion only for boolean type with completion values from sqlline.SqlLineProperty#BOOLEAN_VALUES

Added javadoc for sqlline.SqlLineOpts#optionCompleters
@snuyanzin
Copy link
Collaborator Author

Close PR and will create a new one

@snuyanzin snuyanzin closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants