-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQLLINE-186] Added setting TerminalBuilder.PROP_DUMB before and afte… #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpmletion for properties values like outputformat or boolean properties
…mpmletion for properties values like outputformat or boolean properties
…or copmletion Correct method sqlline.SqlLineOpts#optionCompleters to generate org.jline.builtins.Completers.RegexCompleter for !set command based on (in decreasing order of priority) 1. Customizations 2. Available values defined in BuiltInProperty 3. Type of property. Currently there is completion only for boolean type with completion values from sqlline.SqlLineProperty#BOOLEAN_VALUES Added javadoc for sqlline.SqlLineOpts#optionCompleters
Use Application#getName2HighlightStyle for color scheme available values
…mpletion for properties values like outputformat or boolean properties
snuyanzin
force-pushed
the
scratch_autocompletion
branch
from
November 27, 2018 13:42
cb92fdc
to
f1ff7ca
Compare
…ss susceptible to errors in underlying JDBC driver Wrapper uses reflection, and handles method-not-supported exceptions. In future it could perhaps handle other exceptions, and do caching. Add a test emulating hive behaviour with method not supported. Add "strictJdbc" property to mark whether we should use default values when hitting not-supported/not-implemented methods of DatabaseMetaData.
…ject Use getDeclaredMethods rather than getMethods, and only show public non-static methods.
Correct how we detect whether an input line is SQL, and thereby fix highlighting. Add more tests for highlighting in !sql, !all commands.
…qlLineOpts for maxWidth
Add release notes, and update version number.
Correct release date in release notes.
Document twitter account.
…mpmletion for properties values like outputformat or boolean properties
…or copmletion Correct method sqlline.SqlLineOpts#optionCompleters to generate org.jline.builtins.Completers.RegexCompleter for !set command based on (in decreasing order of priority) 1. Customizations 2. Available values defined in BuiltInProperty 3. Type of property. Currently there is completion only for boolean type with completion values from sqlline.SqlLineProperty#BOOLEAN_VALUES Added javadoc for sqlline.SqlLineOpts#optionCompleters
Close PR and will create a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR sets
TerminalBuilder.PROP_DUMB
property before and after CompletionTest that makes stdout free from errors mentioned in #186 (comment)