Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQLLINE-186] Autocompletion of MODE property values #223

Closed
wants to merge 8 commits into from
Closed

[SQLLINE-186] Autocompletion of MODE property values #223

wants to merge 8 commits into from

Conversation

snuyanzin
Copy link
Collaborator

The PR continues #186

  1. resolves conflict after Update maxColumnWidth default to -1 and add getter to SqlLineOpts for maxWidth #218
  2. fixes warnings mentioned in Tests for completions #186 (comment)
  3. Adds autocompletion for mode property

snuyanzin and others added 8 commits November 19, 2018 14:07
@snuyanzin @julianhyde
[SQLLINE-186] Added tests for completions. Added possibility to do co…
e5f82d9 
…mpmletion for properties values like outputformat or boolean properties
@snuyanzin @julianhyde
[SQLLINE-186] Added tests for completions. Added possibility to do co…
c49539f 
…mpmletion for properties values like outputformat or boolean properties
@snuyanzin @julianhyde
[SQLLINE-186] Make it possible to specify property available values f…
25090d6 
…or copmletion

Correct method sqlline.SqlLineOpts#optionCompleters to generate org.jline.builtins.Completers.RegexCompleter for
!set command based on (in decreasing order of priority)
1. Customizations
2. Available values defined in BuiltInProperty
3. Type of property. Currently there is completion only for boolean type with completion values from sqlline.SqlLineProperty#BOOLEAN_VALUES

Added javadoc for sqlline.SqlLineOpts#optionCompleters
@snuyanzin @julianhyde
[SQLLINE-186] Added test for !reset properties command
540faf5 
Use Application#getName2HighlightStyle for color scheme available values
@julianhyde
fixup
331f8ea
@snuyanzin
[SQLLINE-186] Rebase after SQLLINE-218
824abd8
@snuyanzin
[SQLLINE-186] Added setting TerminalBuilder.PROP_DUMB before and afte…
4c0137e 
…r CompletionTest
@snuyanzin
[SQLLINE-186] Add autocompletion for mode property
de9934a
@snuyanzin snuyanzin mentioned this pull request Nov 29, 2018
Closed
@julianhyde julianhyde force-pushed the scratch branch 4 times, most recently from 7fcab89 to 06fde5d Compare January 11, 2019 23:55
@julianhyde
Copy link
Owner

Merged as 198447d, fixes #186.

@julianhyde julianhyde closed this Jan 14, 2019
@julianhyde julianhyde mentioned this pull request Jan 14, 2019
Closed
@snuyanzin snuyanzin deleted the scratch_autocompletion branch January 15, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snuyanzin @julianhyde