-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQLLINE-228] Set "incremental" to false by default #229
Conversation
This PR didn't touch the docbook manual because it already declares the default value of |
@julianhyde Friendly ping :) |
From my side it looks ok. However I have a question. |
It is a shame that there are so many changes to tests, but I think @liancheng did the right thing in preserving the current behavior of tests as much as possible. @snuyanzin I don't think it's a good idea to have a separate properties file for init. While it would solve this problem, it would confuse users, because it's not a very useful feature for users. I think that non-incremental mode is more important than incremental mode, so in future, I think tests should be written to in the new default, non-incremental mode. (And perhaps some of the tests that were just explicitly made incremental could be converted to non-incremental.) Why is non-incremental mode better? Because it produces smarter column widths, and uses screen real estate more efficiently. A better user experience. I do worry a little bit that in non-incremental mode, statements that return many thousands of rows will use a lot of memory. So, how about making such statements switch to incremental mode after N rows (say N = 1000)? (Not as part of this change; perhaps a feature request for the future?) |
Thank you for your comment. I think you are right about
If am not mistaking there is a very similar feature with configured |
Thanks; I have logged #251. |
This PR tries to address #228 by setting the default value of option
incremental
to false and add an extra help entry for--incremental
.