Fix crash on queue stop #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, I didn't want to have to update v1 before v2 was in |
|
Great, thanks! |
|
Hi @Rycochet - how long do you think the NPM release will take? Is there anything I can do to help? |
Rycochet
pushed a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a crash when stopping a delayed animation in a named queue:
https://jsfiddle.net/apw8wy1p/5/
I see that the second parameter in the queue is correctly handled in Line 4036 but seems to be missing in Line 3007. This PR adds a simple handling of clearQueue at this place, and seems to work for me.
I'd appreciate a bugfix release, since we'd need a npm release to use this fix.