-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developing Logging Feature for 'BinLogStreamReader' Object Creation Parameters #460
Developing Logging Feature for 'BinLogStreamReader' Object Creation Parameters #460
Conversation
i solved the conflicts, and fix typo error! |
Sorry can you rebase your change agaisnt the last main ? |
I merged the contents into the main branch!
|
Before the change, we only considered this parameter as a means to monitor how 'BinLogStreamReader' is configured. However, we felt that there may be additional items to log in this project, so we renamed it to ERRORIn cases where it fails to pass the CRC check. WARNWhen the time of event creation differs from the time of table structure retrieval, leading to incorrect mapping. |
Good ! I will solve the conflict and merge |
@julien-duponchelle I solved confilct and all checks have passed :) |
Hmm seem the conflict solve introduce a problem we have lost the changelog of the new version. I'm going to look at that |
Great you fixed it ! So fast |
oh...I'm sorry that I added this part without it. I fixed it! |
Overview
A functionality has been developed to log the parameters provided by the user when creating a BinLogStreamReader object.
This logging feature is implemented to track the input parameters used to create the object, and it is designed to work within the context of a larger package that might be imported and utilized by other programs.
Therefore, specific log configurations, formats, or handling methods have not been implemented. Instead, this feature has been designed to log messages at the INFO level for visibility.
The parameter 'enable_logging' allows you to check the settings of the BinlogStreamReader object. By default, this parameter is set to 'True'. If you want to disable logging, you can simply set its value to 'False'.
dump_events.py
file as followsBenefits
This functionality provides a clear visibility into "What parameters did the user provide when creating a 'BinLogStreamReader' object?" The logging messages help users understand the configuration and input parameters utilized during the object creation process.