Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Testing with MySQL8 & Update GitHub Actions #484

Conversation

mjs1995
Copy link
Contributor

@mjs1995 mjs1995 commented Sep 21, 2023

Overview

Add MySQL-8 based test (with percona-8.0)

Since below two features need to test based on MySQL version 8,
this PR added percona-8.0 docker and test based on MySQL version 8.

Update github actions version

This PR also updates GitHub Actions to use the latest versions of actions/checkout and actions/setup-python
in preparation for the end-of-life of Node 16 in September 2023.
The default runtime of Node 16 will reach its end-of-life on 11 Sep 2023.
To adapt to this change and benefit from the features and optimizations in the newer GitHub Actions versions.

Change

Add MySQL-8 based test (with percona-8.0)

  • Add percona-8.0 docker image with port 3309
  • Add PyMySQLReplicationVersion8TestCase class in pymysqlreplication/tests/base.py
  • Change TestOptionalMetaData's inheritance
    from base.PyMySQLReplicationTestCase to base.PyMySQLReplicationVersion8TestCase
  • Add TestDataTypeVersion8 class in pymysqlreplication/tests/test_data_type.py

Update github actions version

  • From actions/checkout@v2 to actions/checkout@v4
  • From actions/setup-python@v2 to actions/setup-python@v4
  • From timeout-minutes: 2 to timeout-minutes: 3
    The addition of a new Docker container for Percona 8.0 has led to an increase in the initialization and build time. This caused the GitHub Actions test suite to initially exceed the maximum execution time of 2 minutes. To accommodate the new test requirements, the time limit for the GitHub Actions has been increased to 3 minutes.

Benefits

Add MySQL-8 based test (with percona-8.0)

  • Could test which only works on Mysql verison 8.

Update github actions version

  • Utilizes performance improvements and new features from the latest versions.
  • Prepares the codebase for the end of support for Node 16.

References

Update github actions version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants