Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use callback for countdown reset #326

Closed
wants to merge 2 commits into from
Closed

Use callback for countdown reset #326

wants to merge 2 commits into from

Conversation

gromchen
Copy link

Otherwise, it's a potential infinite loop in useEffect.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 22e72b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliencrn juliencrn added the enhancement Improvements label Jan 23, 2024
@juliencrn juliencrn mentioned this pull request Mar 5, 2024
Merged
@juliencrn
Copy link
Owner

Hi @gromchen,

Thanks for that PR, since the code is too old, I re-created it there (#526).
I added you to the contributor list.

@juliencrn juliencrn closed this Mar 5, 2024
@EchoSkorJjj EchoSkorJjj mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gromchen @juliencrn