Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix useResizeObserver initialSize mutation #504

Conversation

iuriiiurevich
Copy link
Contributor

This PR fixes a mutation of the initialSize, due to which the hook may not work correctly when there is two or more instances of it.

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 9f6de0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
usehooks-ts Patch
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

juliencrn
juliencrn previously approved these changes Feb 22, 2024
Copy link
Owner

@juliencrn juliencrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you 👍

@juliencrn
Copy link
Owner

@all-contributors please add @iuriiiurevich for bug and code

@juliencrn
Copy link
Owner

@all-contributors please add @Yurchishin for bug

Copy link
Contributor

@juliencrn

I've put up a pull request to add @iuriiiurevich! 🎉

Copy link
Contributor

@juliencrn

I've put up a pull request to add @Yurchishin! 🎉

@juliencrn juliencrn merged commit b88cc01 into juliencrn:master Feb 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants