Skip to content

Commit

Permalink
Refactor kind configuration file for testing with K8s-v1.25 (kubeflow…
Browse files Browse the repository at this point in the history
…#2331)

* Fix kind configuration file script

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* tests: Refactor kind configuration file

Have one file for the KinD configuration instead of
version specific ones.

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

* workflows: Update GH Action workflows

- Use the updated KinD configuration file
- Trigger the workflows when Kind configuration file changes

  * Exclude Katib workflow. See:
    kubeflow#2273 (comment)

  * Exclude Kserve workflow, until we update Knative version to v1.8. See:
    kubeflow#2325 (comment)

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>

Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
  • Loading branch information
apo-ger authored and kevin85421 committed Feb 28, 2023
1 parent 060a155 commit 623fba4
Show file tree
Hide file tree
Showing 17 changed files with 24 additions and 86 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/centraldb_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/centraldashboard/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/dex_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- common/dex/base/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/jwa_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/jupyter/jupyter-web-app/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/katib_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kserve_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/nb_controller_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/jupyter/notebook-controller/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pipeline_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/pipeline/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/poddefaults_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/admission-webhook/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/profiles_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/profiles/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/tb_controller_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/tensorboard/tensorboard-controller/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/train_operator_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/training-operator/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/twa_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/tensorboard/tensorboards-web-app/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/vwa_kind_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
pull_request:
paths:
- apps/volumes-web-app/upstream/**
- tests/gh-actions/kind-cluster.yaml

jobs:
build:
Expand All @@ -15,7 +16,7 @@ jobs:
run: ./tests/gh-actions/install_kind.sh

- name: Create KinD Cluster
run: kind create cluster --config tests/gh-actions/kind-cluster-1-25.yaml
run: kind create cluster --config tests/gh-actions/kind-cluster.yaml

- name: Install kustomize
run: ./tests/gh-actions/install_kustomize.sh
Expand Down
24 changes: 0 additions & 24 deletions tests/gh-actions/kind-cluster-1-20.yaml

This file was deleted.

24 changes: 0 additions & 24 deletions tests/gh-actions/kind-cluster-1-21.yaml

This file was deleted.

25 changes: 0 additions & 25 deletions tests/gh-actions/kind-cluster-1-22.yaml

This file was deleted.

File renamed without changes.

0 comments on commit 623fba4

Please sign in to comment.