Adds section Common Performance Pitfall with JuMP. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @odow in #300, this updates the documentation of README.md to give new JuMP.jl+Gurobi.jl users a warning about the most common performance pitfall (so they may be already aware of it and structure their JuMP programs accordingly). This will also probably help users that find the "excessive updates" message and search for how to fix it.
odow
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
This looks great @henriquebecker91. Thanks for your patience.
|
Thanks for your patience.
I could say the same.
I will look into the bounds cache idea, but no guarantees, if I fell it
would add a lot of code or risk messing with existing functionality then I
will not open a PR.
Em sex., 27 de mar. de 2020 às 18:52, Oscar Dowson <notifications@github.com>
escreveu:
… ***@***.**** approved this pull request.
This looks great @henriquebecker91 <https://github.com/henriquebecker91>.
Thanks for your patience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#301 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLVVG3X5RLWO5CKAOYB65LRJUNZZANCNFSM4LVJYCPA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @odow in #300, this updates the documentation of README.md to give new JuMP.jl+Gurobi.jl users a warning about the most common performance pitfall (so they may be already aware of it and structure their JuMP programs accordingly). This will also probably help users that find the "excessive updates" message and search for how to fix it.