Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in setting a negative lower bound of a SOC constrained variable with add_constraints #302

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Fix bug in setting a negative lower bound of a SOC constrained variable with add_constraints #302

merged 3 commits into from
Mar 31, 2020

Commits on Mar 30, 2020

  1. Adds a test uncovering a bug in SOC constraints. The bug was that def… 

    …ining a negative lower bound on the `t` variable of a SOC constraint by means of `add_constraints` (GreaterThan) silently corrupted the related `VariableInfo` object, but using `add_constraint` worked.
    @henriquebecker91
    henriquebecker91 committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    6e84956 View commit details
    Browse the repository at this point in the history

  2. Solves the bug in SOC constraints. The one uncovered by the test adde… 

    …d in the last commit. The bug is solved by reworking many methods to work correctly with batch/vector (that is where the bug appeared) and changing single-element methods to wrap arguments and call the batch/vector variant. This way there will exist no difference in behavior between single-element and batch methods.
    @henriquebecker91
    henriquebecker91 committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    780b43b View commit details
    Browse the repository at this point in the history

  3. Replace our solution by the one proposed by @odow

    @henriquebecker91
    henriquebecker91 committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    2afd713 View commit details
    Browse the repository at this point in the history