Comments overhaul #314
Merged
Comments overhaul #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivity of reduced costs. Added a global const union for a common union. Changed the linebreaks of many comments in an effort to keep them close to 80 characters. Other minor changes.
odow
approved these changes
Apr 22, 2020
blegat
approved these changes
Apr 29, 2020
|
@odow, I have merged master with this PR. It does not change any behavior, it just improves comments and line breaking. It had conflicts because of changes introduced by my other PR (that solved the buffering bug). Some changes were too close to a comment I changed (or replaced the comment with a more appropriate one), no "real" conflict. |
|
Screenshot of tests passing? |
|
|
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comment asked by @blegat. Fixed comment on the negativity/positivity of reduced costs. Added a global const union for a common union. Changed the linebreaks of many comments in an effort to keep them close to 80 characters. Other minor changes.