WIP: preprocessing using QR factorizations #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also i will make preprocessing / rank checks all optional. possibly off by default. |
|
Now I want to pull this out into a new function that would be optionally called before load_data. The function would simply preprocess the c,A,b,G,h. This would work better with the MOI functions and would keep native interface simpler. However it may result in doing a redundant QR. That could be avoided if this function returns the linsys cache object. Then load_data should accept the linsys cache object. This will simplify load_data, which should not be creating the cache. In fact load_data perhaps could just be removed. |
|
replaced by #74 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very WIP. will fix #16