Add vectorized operation tests #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 82.05% 84.03% +1.97%
==========================================
Files 24 24
Lines 3416 3451 +35
==========================================
+ Hits 2803 2900 +97
+ Misses 613 551 -62
Continue to review full report at Codecov.
|
mlubin
reviewed
May 7, 2018
test/operator.jl
Outdated
| @test vec_eq(Xd'*Y, Xd.'*Y) | ||
| @test vec_eq(Y'*Xd, Y.'*Xd) | ||
| @test vec_eq(Xd'*Xd, Xd.'*Xd) | ||
| # @test_broken vec_eq(A*X, B*X) |
There was a problem hiding this comment.
It was commented out in old/operators.jl, I have uncommented them and checked what were the issue, see the description of this PR for details :)
test/operator.jl
Outdated
| @test vec_eq(A.+x, [1+x[1,1] 2+x[1,2]; | ||
| 3+x[2,1] 4+x[2,2]]) | ||
| @test vec_eq(A.+x, B.+x) | ||
| # @test vec_eq(A.+x, A.+y) |
|
Nice boost in coverage for |
mlubin
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented tests in JuMP v0.18 have been uncommented. One of them mentionned that was failing because of #912 but it now works. One of them was failing because of #1275 but a fix is contained in this PR.
A last test is failing because of #1276 but I defer the fix for a later PR.
Closes #912
Closes #1275