Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Add destructive_add! for variable + variable #1636

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Nov 19, 2018

The result of speed.jl on master:

P-Median(100 facilities, 100 customers, 5000 locations) benchmark:
BenchmarkTools.Trial: 
  memory estimate:  1017.98 MiB
  allocs estimate:  16531537
  --------------
  minimum time:     2.028 s (44.50% GC)
  median time:      2.303 s (52.62% GC)
  mean time:        2.320 s (52.55% GC)
  maximum time:     2.630 s (58.70% GC)
  --------------
  samples:          3
  evals/sample:     1
Cont5(n=500) benchmark:
BenchmarkTools.Trial: 
  memory estimate:  421.65 MiB
  allocs estimate:  7545407
  --------------
  minimum time:     915.800 ms (41.56% GC)
  median time:      1.003 s (43.59% GC)
  mean time:        999.647 ms (43.82% GC)
  maximum time:     1.078 s (45.62% GC)
  --------------
  samples:          6
  evals/sample:     1

With this PR

P-Median(100 facilities, 100 customers, 5000 locations) benchmark:
BenchmarkTools.Trial: 
  memory estimate:  735.64 MiB
  allocs estimate:  13030837
  --------------
  minimum time:     1.416 s (35.18% GC)
  median time:      2.219 s (58.35% GC)
  mean time:        2.012 s (53.49% GC)
  maximum time:     2.401 s (59.80% GC)
  --------------
  samples:          3
  evals/sample:     1
Cont5(n=500) benchmark:
BenchmarkTools.Trial: 
  memory estimate:  421.08 MiB
  allocs estimate:  7538407
  --------------
  minimum time:     912.507 ms (41.36% GC)
  median time:      971.512 ms (43.71% GC)
  mean time:        971.481 ms (43.99% GC)
  maximum time:     1.038 s (46.60% GC)
  --------------
  samples:          6
  evals/sample:     1

Related to #1403

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #1636 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files          28       28           
  Lines        3744     3744           
=======================================
  Hits         3402     3402           
  Misses        342      342
Impacted Files Coverage Δ
src/parse_expr.jl 94.9% <100%> (+0.02%) ⬆️
src/macros.jl 89.89% <0%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61020c...38e1e56. Read the comment docs.

@blegat blegat merged commit 2f268b1 into master Nov 20, 2018
@blegat blegat deleted the bl/var+var branch December 12, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants