Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build docs as a PDF #2760

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Build docs as a PDF #2760

merged 4 commits into from
Oct 28, 2021

Conversation

odow
Copy link
Member

@odow odow commented Oct 18, 2021

docs/src/developers/style.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #2760 (c82707d) into master (876258c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2760   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          43       43           
  Lines        5522     5522           
=======================================
  Hits         5205     5205           
  Misses        317      317           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 876258c...c82707d. Read the comment docs.

@mlubin
Copy link
Member

mlubin commented Oct 18, 2021

Wow, that's a long pdf. We can change the authors on the first page to something like "The JuMP core developers and contributors".

@odow
Copy link
Member Author

odow commented Oct 18, 2021

Yeah there's a few things I'd like to fix:

image

image

@odow
Copy link
Member Author

odow commented Oct 19, 2021

Still some problems building the LaTeX:

image

  • Portfolio example

image

  • Space shuttle

image

@odow odow changed the title WIP: build docs as a PDF Build docs as a PDF Oct 19, 2021
@odow odow added this to the 1.0 milestone Oct 19, 2021
@odow odow removed this from the 1.0 milestone Oct 20, 2021
@odow
Copy link
Member Author

odow commented Oct 21, 2021

Finally we have success: https://jump.dev/JuMP.jl/previews/PR2760/JuMP.pdf

Since things are building, this isn't blocking for JuMP 0.22. It can wait until we release a new version of MOI. I also need to tidy up the fact that each page should have a level-1 heading for the chapter (e.g., index.md doesn't), and there are a couple of broken links to sort.

The bigger issue is that the doc run is now 30 minutes! We may want to consider only enabling this before each release, rather than on every PR.

@odow
Copy link
Member Author

odow commented Oct 21, 2021

Here's the upstream issue for tables: JuliaDocs/Documenter.jl#1205

@odow odow force-pushed the od/pdf branch 2 times, most recently from 7be8882 to b2ad204 Compare October 24, 2021 07:33
@odow
Copy link
Member Author

odow commented Oct 26, 2021

Currently blocked by #2780

@odow
Copy link
Member Author

odow commented Oct 27, 2021

Here's the current build:

https://jump.dev/JuMP.jl/previews/PR2760/JuMP.pdf

So the time breakdown is:

  • Install Julia: 280 seconds
  • Literate examples: 300 seconds
  • Build HTML: 265 seconds
  • Build LaTeX: 835 seconds

So the LaTeX is a pretty sizable hit. Splitting the jobs into a parallel HTML and PDF build steps wouldn't help us very much. It's save a couple of minutes, but it'd complicate the PDF deployment. It's nice having everything in a single build step.

Overall, I'd suggest we merge this and see if we get annoyed by the 30 minute doc build. I can see that if we don't run the LaTeX build every time, we're quickly going to end up where the LaTeX doesn't build and we have to spend a lot of time debugging it before each release.

Having an up-to-date preview PDF is also quite useful for editing.

@odow
Copy link
Member Author

odow commented Oct 28, 2021

Merging this until I get annoyed by it.

@odow odow merged commit db281ec into master Oct 28, 2021
@odow odow deleted the od/pdf branch October 28, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Generate a PDF version of the docs
2 participants