-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs as a PDF #2760
Build docs as a PDF #2760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 43 43
Lines 5522 5522
=======================================
Hits 5205 5205
Misses 317 317 Continue to review full report at Codecov.
|
Wow, that's a long pdf. We can change the authors on the first page to something like "The JuMP core developers and contributors". |
Yeah there's a few things I'd like to fix:
|
Still some problems building the LaTeX:
|
Finally we have success: https://jump.dev/JuMP.jl/previews/PR2760/JuMP.pdf Since things are building, this isn't blocking for JuMP 0.22. It can wait until we release a new version of MOI. I also need to tidy up the fact that each page should have a level-1 heading for the chapter (e.g., The bigger issue is that the doc run is now 30 minutes! We may want to consider only enabling this before each release, rather than on every PR. |
Here's the upstream issue for tables: JuliaDocs/Documenter.jl#1205 |
7be8882
to
b2ad204
Compare
Currently blocked by #2780 |
Here's the current build: https://jump.dev/JuMP.jl/previews/PR2760/JuMP.pdf So the time breakdown is:
So the LaTeX is a pretty sizable hit. Splitting the jobs into a parallel HTML and PDF build steps wouldn't help us very much. It's save a couple of minutes, but it'd complicate the PDF deployment. It's nice having everything in a single build step. Overall, I'd suggest we merge this and see if we get annoyed by the 30 minute doc build. I can see that if we don't run the LaTeX build every time, we're quickly going to end up where the LaTeX doesn't build and we have to spend a lot of time debugging it before each release. Having an up-to-date preview PDF is also quite useful for editing. |
Merging this until I get annoyed by it. |
Preview: https://jump.dev/JuMP.jl/previews/PR2760/JuMP.pdf
Closes #1881
Needs